A variety of fixes pulled from the ninja-keys repo

KonnorRogers / konnors-ninja-keys

Ninja Keys fork!

https://konnorrogers.github.io/konnors-ninja-keys/

MIT License

9 stars 2 forks source link

A variety of fixes pulled from the ninja-keys repo #9

Closed KonnorRogers closed 7 months ago

KonnorRogers commented 7 months ago

Add better escape regex and expose a function to override. https://github.com/ssleptsov/ninja-keys/pull/33
Fix syntax error in README https://github.com/ssleptsov/ninja-keys/pull/38
Add guard clause for _inputRef https://github.com/ssleptsov/ninja-keys/pull/38

jwoertink commented 7 months ago

Nice! This is great that you're taking this on. I love the library, but definitely been frustrating not having consistent fixes and updates. Just leaving a comment here so I can watch for when this is merged and give your fork a shot. Thanks!

KonnorRogers commented 7 months ago

@jwoertink I've actually been maintaining this fork for ~9months starting with this PR here:

https://github.com/ssleptsov/ninja-keys/pull/47

I've been using it in all of my personal sites.

This PR is just additional cleanup and scaffolding up an actual docs site with examples.

https://github.com/KonnorRogers/konnors-ninja-keys/blob/main/CHANGELOG.md#130

Starting at 1.3.0 has the changes I've been adding!

Feel free to open additional issues if there's anything else you'd like to see / you're missing / any bugs!

jwoertink commented 7 months ago

Sweet. I've been using my own fork, but I'll give yours a shot. Thanks!