search

KonradIT / gopro-py-api

Unofficial GoPro API Library for Python - connect to GoPro via WiFi.
MIT License
1.39k stars 211 forks source link

Downloading more than 999 timelapse-images #124

Open mabeckgit opened 4 years ago

mabeckgit commented 4 years ago

Describe the bug First: Thanks a lot for providing this API, it saved us so much work!

The GoPro 7 Black (and I assume others too) save files in subfolders, each subfolder containing up to 999 files. When I use the downloadAll function in GoProCamera.py it only downloads the latest folder and none of the older ones. In my application I let the GoPro run for hours and create about 3000+ images and would love to download them all in one go afterwards.

Edit: This seems only to happen when taking a timelapse of 1000+ images

2nd Edit: Now I also encountered the problem with just images (not timelapse). :(

To Reproduce Steps to reproduce the behavior:

  1. Take more than 999 images
  2. run GoProCamera.downloadAll('all')

Expected behavior Downloading all images.

Desktop (please complete the following information):

I should note, I changed the code a bit, such that a destination-folder can be given to downloadAll. The changes exactly are: Line 890: def downloadAll(self, option="", prefix=''): and Line 904: self.downloadMedia(folder, file, custom_filename=prefix+folder+"-"+file)

nothing else was changed.

dmt0 commented 3 years ago

Seeing a similar issue with GoPro Hero 5 Black. I currently have two folders on the Cam: 100GOPRO and 101GOPRO

downloadAll() only downloads the first file from each folder.