KonradIT / mmt

Media Management Tool - make importing videos/photos from GoPro and other action cameras/drones a little bit more bearable.
http://mmt.camera
Apache License 2.0
96 stars 11 forks source link

use partition.Mountpoint instead of .Device #130

Closed klaernie closed 1 month ago

klaernie commented 1 month ago

use partition.Mountpoint instead of .Device

Under Windows both properties carry the same value, yet under Linux .Device is the name of the block device like /dev/sdc1 and mountpoint is the place in the filesystem where this device is mounted and where one can access the data in it - like /mnt/insta-sdcard.

Hence when trying to access files like MISC/version.txt, DCIM/fileinfo_list.list or MISC/GIS/dji.gis it will not work.

Switching to .Mountpoint means file access under Linux will start to work, and keep working under Windows.

Type:

Camera:

Component:

Checklist before approval:

KonradIT commented 1 month ago

Thanks, I'll apply this PR without passing linter / tests and then fix it myself afterwards.

klaernie commented 1 month ago

Cool! Thanks for merging! Once you've fixed the linter and test I'd happily rebase my other PRs.