KonradIT / mmt

Media Management Tool - make importing videos/photos from GoPro and other action cameras/drones a little bit more bearable.
http://mmt.camera
Apache License 2.0
108 stars 12 forks source link

some flags are not working for me on linux with hero 9 #3

Closed jensMF closed 3 years ago

jensMF commented 3 years ago

Hi,

thank you for your tools, they are really helpful!

I have a problem with the linux version and my GoPro Hero 9: I tried to use the -d (--date) and the -s (--skip_aux) flags, but I get the default behavior. (I tried -d yyyy-mm-dd -s false and -d "yyyy-mm-dd" -s THM.) I want to import the .LRV files, too.

Maybe I did not use them correctly?

I also tried to use -v but that did not change anything as well.

jensMF commented 3 years ago

I found the solutions for both problems. The -s (--skip_aux) flag has to be used like this: -s=false (--skip_aux=false)

The date flag can not work due to a small bug. A replacement to have a correct date-format string in Go is only done for yyyy, mm and dd. e.g.: https://github.com/KonradIT/mmt/blob/768eb8d5162b06daa3b3744126ea35b8e30313bf/pkg/dji/dji.go#L92 A check if all three necessary parts of a date string are present is checks for "year", "month" and "day". e.g: https://github.com/KonradIT/mmt/blob/768eb8d5162b06daa3b3744126ea35b8e30313bf/pkg/dji/dji.go#L129-L131

(For reference: https://github.com/KonradIT/mmt/blob/768eb8d5162b06daa3b3744126ea35b8e30313bf/pkg/android/android.go#L43-L45 https://github.com/KonradIT/mmt/blob/768eb8d5162b06daa3b3744126ea35b8e30313bf/pkg/dji/dji.go#L174-L176 https://github.com/KonradIT/mmt/blob/768eb8d5162b06daa3b3744126ea35b8e30313bf/pkg/gopro/connect.go#L129-L131 https://github.com/KonradIT/mmt/blob/768eb8d5162b06daa3b3744126ea35b8e30313bf/pkg/gopro/gopro.go#L359-L361 https://github.com/KonradIT/mmt/blob/768eb8d5162b06daa3b3744126ea35b8e30313bf/pkg/gopro/gopro.go#L581-L584 https://github.com/KonradIT/mmt/blob/768eb8d5162b06daa3b3744126ea35b8e30313bf/pkg/gopro/gopro.go#L794-L796 https://github.com/KonradIT/mmt/blob/768eb8d5162b06daa3b3744126ea35b8e30313bf/pkg/insta360/insta360.go#L146-L148