Solved issue #5 sound effects

KonradLinkowski / Stack

Tower stacking game made using Three.js

https://konradlinkowski.github.io/Stack/

MIT License

9 stars 2 forks source link

Solved issue #5 sound effects #7

Open sanket95droid opened 1 year ago

sanket95droid commented 1 year ago

Used Three.js Audio section for adding audio :

[x] Sound after clicking the tile
[x] background music

sanket95droid commented 1 year ago

@KonradLinkowski did the requested changes except for the button please review it.

KonradLinkowski commented 1 year ago

@sanket95droid hey, please remove changes to package-lock.json and yarn.lock I will update them manually in the next commit

sanket95droid commented 1 year ago

@KonradLinkowski ok, should I also remove changes to package.json because it is also causing merge conflict or only package-lock.json and yarn.lock???

KonradLinkowski commented 1 year ago

@sanket95droid yes I fixed the issue you mentioned earlier about node-gyp etc.

sanket95droid commented 1 year ago

@KonradLinkowski please compare and merge my PR!!

KonradLinkowski commented 1 year ago

@sanket95droid I can't merge it because you didn't resolve the conflicts. But I added hacktoberfest-accepted it should appear as being accepted for hacktoberfest

sanket95droid commented 1 year ago

Ohk i'll try to resolve those conflits and make a commit @KonradLinkowski

sanket95droid commented 1 year ago

Ohk i'll try to resolve those conflits and make a commit @KonradLinkowski

@KonradLinkowski Done ✅