search

KonstantinCodes / messenger-kafka

Simple Kafka transport for Symfony Messenger.
MIT License
84 stars 35 forks source link

Stable branch ready to be used ? #5

Closed jbouzekri closed 4 years ago

jbouzekri commented 4 years ago

I see a stable branch with rdkafka 4.x support. Is it ready to be used in production ? Are you going to merge it in master ? If not, can you provide a todo list of all the things it needs to be done to merge it ?

KonstantinCodes commented 4 years ago

hi @jbouzekri

Pretty much the only difference is that master continues to consume even after an exception has been thrown. This is not really what we want to happen with the kafka topics. So i made the stable branch.

Would you take a look at master to ensure it actually stops, when an exception is thrown?

Then I can delete stable

jbouzekri commented 4 years ago

Okay. I am going to try the master branch with a 4.x librdakfa installed and focus on how the different error cases are handled. I will let you know once I have the result.

nitso commented 4 years ago

Hello. Do you have any news on this topic?

KonstantinCodes commented 4 years ago

@nitso Yeah, master now supports rdkafka 4

nitso commented 4 years ago

That's great news, thanks!