search

KonstantinGasser / sherlock

easy to use and simple cli password manager
Apache License 2.0
3 stars 2 forks source link

Fix README for group & account commands #24

Open amit-pub opened 3 years ago

amit-pub commented 3 years ago
  1. While adding a group, --group is required

Readme says:

sherlock add group detective

Existing behavior:

# sherlock add group g7
❗ account name required (--name)
  1. While adding an account to a group, --name is required

Readme says:

sherlock add account bakerstreet --gid detective --tag 221b

Existing behavior:

# sherlock add account  g1-a2 --gid g8 --insecure
❗ account name required (--name)
KonstantinGasser commented 3 years ago

@amit-pub thanks for pointing this out. Forgot to align the README when I did my last changes - thanks! 👍

amit-pub commented 3 years ago

@KonstantinGasser I've created the PR for the same already - https://github.com/KonstantinGasser/sherlock/pull/25 you can approve if its LGTY & Merge!