KonstantinGasser / sherlock

easy to use and simple cli password manager
Apache License 2.0
3 stars 2 forks source link

deleting a group #3

Closed KonstantinGasser closed 3 years ago

KonstantinGasser commented 3 years ago

IMO the user should be able to delete a group - however there are some things to consider:

amit-pub commented 3 years ago
KonstantinGasser commented 3 years ago

@amit-pub thanks for your thoughts on that. For the first point I think we misunderstood: deleting a group with multiple account should work without deleting each account by itself (as mentioned in point 2.). However, if the last account in a group gets deleted should the group then also be automatically be deleted - I think it should not..

Regarding your second point: I agree with you that for now a rollback is not so much required. An idea I had is similar to yours, that a some point it would be cool so have a service running in a local network and accounts could have shared permission and can be retrieved by multiple people in the networking with the right permissions. At this stage thinking about a rollback feature could make sense, yes 😄!

However for this issue I think deleting a group should be the only concern. something like sherlock del group group-name deletes a group instantly if no account are mapped to it, else asks for confirmation, what du you think?