search

KonstantinosRekoumis / CSR

A primitive calculator that calculates a ship midship plates and PSMs based on IACS CSR
2 stars 2 forks source link

Deepen project structure hierarchy to reduce number of classes in specific grossly overloaded "god files" #5

Closed gerelef closed 9 months ago

gerelef commented 9 months ago

Issue

Some files currently suffer from being "god files" if you will, since they are thousands of lines long for no good reason; they just a lot of different classes in the same file. This makes it harder to collaborate on different parts of the project with multiple, since everything is coupled together on the same file, making the experience of merge requests significantly worse.

Proposal

Split every class to it's own file & create directories according to responsibility, rather than inserting everything in the same file. Files with very similar functionality should be on the same directory depth.

KonstantinosRekoumis commented 9 months ago

Working on it

KonstantinosRekoumis commented 9 months ago

Did changes to that direction see latest commit

gerelef commented 9 months ago

looks good right now, I'll take a deeper look later note: you can link commits and pull requests with specific issues

gerelef commented 9 months ago

Please add input on whether or not this issue is finished. I think with the latest PR, this is ready to be closed.