Konstanty / libmodplug

libmodplug GitHub repository
Other
134 stars 41 forks source link

Having trouble looping sounds #51

Open danilolc opened 3 years ago

danilolc commented 3 years ago

The library isn't looping my sounds, even with the setting mLoopCount set to -1.

Why is this line commented? https://github.com/Konstanty/libmodplug/blob/d7ba5efd5816696fba668a23194940f796d62b95/src/sndmix.cpp#L368 It will always run the return FALSE on the next line and invalidate some lines of code. The loop will work again if I uncomment this line and line 401.

AliceLR commented 3 years ago

These lines being commented out seems pretty pointless. I wonder if this was just an oversight that never got corrected (this issue has existed since at least 2005).