search

Kopano-dev / kopano-docker

Unofficial Kopano Docker images for all Kopano services.
MIT License
21 stars 12 forks source link

Kopano spamd, Bugfixes #17

Closed h44z closed 4 years ago

h44z commented 4 years ago
fbartels commented 4 years ago

Hi @h44z,

thanks for you pr. Authentification for curl was recently already discussed in https://github.com/zokradonh/kopano-docker/issues/429. Instead of parsing the file manually I would recommend to use --netrc-optional for the curl command. The apt_auth file has the same layout as netrc, additionally with this option there won't be an issue if the file is missing (although it will be created by the Makefile if it does not yet exist).

I have a few more remarks that I'ĺl make inline.

fbartels commented 4 years ago

Oh, and what this pr is also still missing is "what to do with the files generated by kopano-spamd?". Not quite sure myself how to get these files into the mailserver container.

h44z commented 4 years ago

Oh, and what this pr is also still missing is "what to do with the files generated by kopano-spamd?". Not quite sure myself how to get these files into the mailserver container.

The only purpose of kopano-spamd is to write eml files to either a spam or a ham folder. So a user can then either mount the spamd volume with the folders to another container (mail server for example), or use any other script (for example inotify-spamlearn) to further process the exported eml files.

h44z commented 4 years ago

Hi @h44z,

thanks for you pr. Authentification for curl was recently already discussed in zokradonh#429. Instead of parsing the file manually I would recommend to use --netrc-optional for the curl command. The apt_auth file has the same layout as netrc, additionally with this option there won't be an issue if the file is missing (although it will be created by the Makefile if it does not yet exist).

I have a few more remarks that I'ĺl make inline.

I changed it to use --netrc-file if apt_auth.conf exists. So we do not need to duplicate the file to .netrc. This should fix the problem with version.sh mentioned in https://github.com/zokradonh/kopano-docker/issues/429.

fbartels commented 4 years ago

I changed it to use --netrc-file if apt_auth.conf exists

it seems we have misunderstood each other a bit. But the end result is exactly what I had in mind as well.

The only "missing" thing is that you do not need credentials for the z-push repo. Let me know if you want to adapt this (otherwise I can change it after this pr has been merged).

h44z commented 4 years ago

The only "missing" thing is that you do not need credentials for the z-push repo. Let me know if you want to adapt this (otherwise I can change it after this pr has been merged).

I removed the authentication from the z-push repo. Should be good now =)

fbartels commented 4 years ago

Thanks. Tests turned green and the change is merged.