search

Kopano-dev / mattermost-plugin-kopanowebmeetings

Adds WebRTC functionality to the Mattermost WebApp with the help of Kopano Web Meetings
Apache License 2.0
4 stars 3 forks source link

Plugin does not work with right sidebar #1

Closed sraupach closed 6 years ago

sraupach commented 6 years ago

If the Plugin is active in mattermost the expanded sidebar does not push the buttons to the middle of Mattermost. So if i have threaded conversation the upload & emoji Button from the main windows will be behind the sidebar. Bottom grafik

TOP grafik

fbartels commented 6 years ago

Hi @sraupach,

thanks for your report. Which version of Mattermost and the plugin are you using? I have seen this happening before, but cannot reproduce it on my test system anymore (Mattermost 5.0.0 and kopanowebmeetings - 0.1.0-8-g9d69b3e)

sraupach commented 6 years ago

I am using Mattermost 5.0.0 and Plugin 0.1.0-10-g3ff8631

fbartels commented 6 years ago

Ok, gave it another spin and the overlapping only occurs when you actually search (so hit enter and have results displayed). I've created https://jira.kopano.io/browse/KWM-70 (ticket not public at the moment, because of the permissions on the project). Will update here once the issue is resolved.

sraupach commented 6 years ago

On our environment the problem exsist without using the searchbar. Could you confirm that even your buttons on the main window are hidden? Good Case: grafik Issue: grafik

if i search the issue gets worse (i entered "s") :) grafik

fbartels commented 6 years ago

ah, interesting. I thought that the search results overlay the chat messages was supposed to be like this, but it indeed does not happen when the webmeeting plugin is deactivated. will update the internal ticket in this regard.

janwiesmann commented 6 years ago

Any update on this one?

fbartels commented 6 years ago

Hi @janwiesmann,

this issue should have been resolved with https://github.com/Kopano-dev/mattermost-plugin-kopanowebmeetings/commit/69d5ee0a4b7cd602ecab75a3ccb2d078f2b38fb8. I just made a small repro test with an old 0.1.0 version and the latest and was not able to reproduce it anymore after updating to the lastest package.

fbartels commented 6 years ago

We had a bit of confusion here, we at first it seemed this is fixed, but we actually still need to put some work into this. reopening.

janwiesmann commented 6 years ago

@fbartels I'm curious: What's your timeline for resolving this issue?

fbartels commented 6 years ago

Hi @janwiesmann ,

its on our todo list, but since we do not have any customer running this plugin until now it has no high priority for us. Mattermost is planning some breaking changes to the plugin architecture for the 5.2 release, maybe that could be a good opportunity to solve this as well.

If you are using the plugin in a commercial context it may also be an idea to get in contact with our sales team, so we can reorganise priorities for this.

fbartels commented 6 years ago

Hi @sraupach,

the plugin just got updated for Mattermost >=5.2 compatibility. While there are still some known issues (ringtone does not load and after the plugin has been enabled there is a javascript error that forces users to reload mattermost), the original error of this thread cannot be observed anymore.