search

KorAP / Kalamar

:octopus: Mojolicious-based Frontend for KorAP
BSD 2-Clause "Simplified" License
7 stars 2 forks source link

Improve Docker image #116

Open Akron opened 4 years ago

Akron commented 4 years ago

Here I would gather some ideas to improve the docker image for Kalamar.

The current docker image will basically have the Mojolicious script as its entrypoint. This is pretty flexible, but could be improved by

~~- Adding a command to enter the shell in the container (This may be a Mojo command or a simple entrypoint switch script like here.)~~

Akron commented 4 years ago

One improvement, that is not necessary related to docker, is the run-time integration of kalamar.conf.js. If we want to switch to docker for production deployment, it is necessary to support the configuration in runtime, so we do not have to rebuild the docker image just because we want to have, e.g., different annotations in the annotation helper.

Akron commented 4 years ago

I removed the first comment regarding shell. It's more common to use docker exec for this purpose - and because of the USER this already works fine in the current image.