search

KorAP / Krill

:mag: A Corpus Data Retrieval Index using Lucene for Look-Ups
BSD 2-Clause "Simplified" License
16 stars 3 forks source link

SpanQuery serialization of a relation with an attribute #63

Open margaretha opened 4 years ago

margaretha commented 4 years ago

Serialization of a relation with an attribute should be updated. Currently it is serialized into a SpanWithAttribute. However, SpanAttribute would be sufficient because it describes the start and end positions of the element/relation it belongs to.

See de.ids_mannheim.korap.query.TestSpanRelationQueryJSON.testMatchBothRelationNodesWithAttribute()

The KoralQuery used in the test should also be simplified by removing layer and match in koral:span.