Kord-Extensions / ext-mappings

Minecraft mappings extension
MIT License
0 stars 2 forks source link

Configurable Channels #1

Closed TheGlitch76 closed 3 years ago

TheGlitch76 commented 3 years ago

Summary

Channels right now are fairly hardcoded and include references that aren't needed in many discord servers (Namely, Patchwork, which I would like to be removed)

Current Behavior

The Legacy and Patchwork channels are hardcoded to 1.2.5 and 1.14.4 respectively, and are always present

Preferred Behavior

Server owners or bot maintainers should have an easy way to create their own channels through commands or configuration in the bot, and these default alternative channels (besides default and snapshot) should be removed

boring-cyborg[bot] commented 3 years ago

Hello, and thanks for opening an issue! As this is the first time you've created an issue on this repository, we'd just like to offer you a warm welcome to the project, and the following pointers:

gdude2002 commented 3 years ago

The main issue with configurable channels is, from a cursory glance, that hardcoded channels seem to be a Linkie concept - specifically, we're working with Linkie enums here.

It may well be possible to make things configurable to that level - this is just an early note on the issue.

TheGlitch76 commented 3 years ago

From my cursory glance at the code #2 absolutely requires replacing linkie core's YarnNamespace, so if #2 is going to be implemented that shouldn't be a concern

gdude2002 commented 3 years ago

Yarn's extra channels may now be configured - although Patchwork is the only extra channel that linkie-core supports right now.

Commit: https://github.com/Kord-Extensions/ext-mappings/commit/4c45a299c795fbf7e2f21e389aea84ec749a6928

This hasn't yet been tested, so I'm not closing the issue yet.

Bear in mind that Yarn is the only mappings provider we support that actually has channels other than "official" and "snapshot".

gdude2002 commented 3 years ago

After some testing, I'm going to say this issue is solved. Feel free to let me know if not!