Kord-Extensions / ext-mappings

Minecraft mappings extension
MIT License
0 stars 2 forks source link

insert semicolon in Lclass;method for mixin target #5

Closed spaceclouds42 closed 3 years ago

spaceclouds42 commented 3 years ago

Fixes: When getting mappings for a method, the mixin target is missing the semicolon between the class and the method name. For instance, ?ym TickCriterion.trigger will give the target:

Lnet/minecraft/advancement/criterion/TickCriteriontrigger(Lnet/minecraft/server/network/ServerPlayerEntity;)V
should have a semicolon here ---------------------^

This error does not occur for field mixin targets

boring-cyborg[bot] commented 3 years ago

Hello, and thanks for opening a pull request! As this is your first pull request to this repository we'd just like to offer you a warm welcome to the project, and the following pointers:

gdude2002 commented 3 years ago

Thanks for that!

boring-cyborg[bot] commented 3 years ago

Congratulations, you've just scored your first merged pull request to this repository! Thanks for your contribution - your changes are currently being built and will be deployed automatically. Kotlin Discord UG exists to support its users, and it's people like you that help to shape our path as we move forward. We couldn't do what we do without your support!