Kord-Extensions / kord-extensions

Kord extensions framework, providing commands and distinct units of functionality

https://kordex.dev

European Union Public License 1.2

110 stars 27 forks source link

StringConverter length validation translation keys switched #290

Closed Iliasgx closed 5 months ago

Iliasgx commented 5 months ago

Description

The translation keys used to throw a DiscordRelayedException in the StringConverter are switched in case a length requirement is not met.

minLength req not met uses the key: converters.string.error.invalid.tooLong
maxLength req not met uses the key: converters.string.error.invalid.tooShort

Source code

https://github.com/Kord-Extensions/kord-extensions/blob/377d0f1e3816ce7de903aafcfc2415c42b761e1c/kord-extensions/src/main/kotlin/com/kotlindiscord/kord/extensions/commands/converters/impl/StringConverter.kt#L55-L71

Suggestions

Simple solution, the translation keys should be switched:

minLength req not met: converters.string.error.invalid.tooShort
maxLength req not met: converters.string.error.invalid.tooLong

gdude2002 commented 5 months ago

Good catch, thank you!