search

Kord-Extensions / kord-extensions

Kord extensions framework, providing commands and distinct units of functionality
https://kordex.dev
European Union Public License 1.2
110 stars 27 forks source link

Fix Exception when running with KSP2 #301

Closed DRSchlaubi closed 3 months ago

DRSchlaubi commented 3 months ago

Seemingly Enum constants are now KSClassDeclarations rather than KSTypes

gdude2002 commented 3 months ago

The branch you've targeted does not support K2 - did you mean to target the K2 branch?

DRSchlaubi commented 3 months ago

The branch you've targeted does not support K2 - did you mean to target the K2 branch?

I specifically said KSP2 not K2, the project seems to work fine on KSP2 when not using k2

gdude2002 commented 3 months ago

Is there a reason to rush the usage of KSP 2 before we can even use K2?

DRSchlaubi commented 3 months ago

Is there a reason to rush the usage of KSP 2 before we can even use K2?

I want to upgrade my project to KSP2 and this prevents me from doing so haha

Also it doesn't seem to cause issues with k1 users, so why not upgrade to KSP2 while we can, seems to have no downside

gdude2002 commented 3 months ago

Did you test the converter system via the test bot?

DRSchlaubi commented 3 months ago

Did you test the converter system via the test bot?

I did not, I assumed if KSP would cause issues they would be compile-time issues, not runtime issues

gdude2002 commented 3 months ago

Thanks!