createdAtStart Koin flag is ignored

[derkalaender]

Description

Creating a Koin module or definition inside of the beforeKoinSetup hook, the createdAtStart flag gets ignored, as those modules/definitions do not in fact get instantiated at start. This flag is useful for Database connections for example, which need to be established directly at application start to do migrations etc.

This might not be a deal-breaker at first, since you could just instantiate the object yourself (if it doesnt inject anything) and then create a single from that. However, things get difficult when that object itself has other dependencies. So you'd either need to use getKoin() manually or create those other dependencies outside of Koin as well, which might get ugly pretty quickly.

Versions

Latest Kord Extensions 1.5.0-SNAPSHOT

Code Examples

class MyDatabase(dep: DepOne) : KoinComponent, KLoggable {
    override val logger: KLogger = logger()

    val otherDep: DepTwo by inject()

    init {
        logger.info { "Setting up database with dependencies $dep and $otherDep" }
    }
}

suspend fun ExtensibleBotBuilder.setupDatabase() {
    hooks {
        beforeKoinSetup {
            loadModule {
                single(createdAtStart = true) { MyDatabase(get()) }
            }
        }
    }
}

No log can be seen (only once another object uses MyDatabase). MyDatabase can also not be instantiated externally because of the inject

Suggestions

Here in setupKoin() the startKoin() is called before running the runBeforeKoinSetup hooks. This might be the culprit, because according to Koin docs, anything flagged with createdAtStart is executed once startKoin is called and at that point, the modules have not been registered yet.

[boring-cyborg[bot]]

Hello, and thanks for opening an issue! As this is the first time you've created an issue on this repository, we'd just like to offer you a warm welcome to the project, and the following pointers:

• Most importantly, all issues must adhere to our Code of Conduct. Please give it a quick read if you haven't already.
• While our team is passionate about the projects we've created here, we're all volunteers. Please don't be offended if it takes time for us to get to your issue - we'll be here as soonas we can be!

• Please provide as much information as possible when asking a question, reporting a problem, or submitting a feature request. This will help us to address your issue quickly and efficiently. If you forgot to add some information, no worries - feel free to edit the issue and add anything you missed!

  Thanks for contacting us! If you have any further questions, please feel free to join us on Discord in the #dev-kotdis channel (or #kordex-discussion for Kord Extensions projects), or to contact a staff member directly.

[gdude2002]

Hello, just getting around to this now!

Do you know if modules can be registered globally before startKoin is called? I guess the implication here is that they can, but it'd be good to double-check whether getKoin is safe to use that early.

I'll look into it.

[gdude2002]

Nope, loadKoinModules() can't be called before startKoin - any ideas?

[gdude2002]

Marking this stale as it hasn't been updated in 5 days.

[gdude2002]

This hasn't been updated for 10 days, and I'm at a loss as to how this could be implemented. As the reporter seems to have disappeared, I'll be closing this issue now - if you have any further ideas or a proof of concept, please feel free to open another issue or comment on this one.