KorryKatti / Mirage

a chat app which doesn't store messages on the server
MIT License
9 stars 18 forks source link

Fix message duplication and improve chat room handling #12

Closed spline2hg closed 1 month ago

spline2hg commented 1 month ago

Message Duplication Fix and Chat Improvements

Problem

Users experienced message duplication when clicking on chat rooms multiple times. This was caused by:

  1. Redundant message loading from both local storage and server

Solution

This PR implements a comprehensive fix for message handling:

Client Changes

Server Changes

Testing Done

Please review the code thoroughly for any potential issues or improvements, as I'm still learning and appreciate any feedback

KorryKatti commented 1 month ago

will take a look into it and it will approve/disapprove in an hour

spline2hg commented 1 month ago

ok yeah ,great

KorryKatti commented 1 month ago

checked to be working , merging now

Thank you for your PR

spline2hg commented 1 month ago

yeah cool man