search

KorryKatti / Mirage

a chat app which doesn't store messages on the server
MIT License
9 stars 18 forks source link

Worked and Implemented Issue#40 #41

Closed nub-rin closed 1 month ago

nub-rin commented 1 month ago

I have successfully Implemented #40

I try to test every possible scenarios I can think, but If i missed any. Kindly ping me so that I can take a look and help fix it.

Any suggestions is much appreciated!!

Happy Hacking!

KorryKatti commented 1 month ago

will check and let you know. Thanks for the PR

KorryKatti commented 1 month ago

@nub-rin It works flawlessly , just one small issue

whenever user enters wrong password it shows wrong password entered but then the room button just become unclickable to make way for a second try. The user is having to restart the client to click again. Fix that and the PR will be merged

nub-rin commented 1 month ago

Alright! I'll work on it and send a PR.

nub-rin commented 1 month ago

@KorryKatti I have managed to narrow down the issue and fixed it and pushed the fix to the branch, kindly check it out and let me know if you find any more issues.

Happy Hacking!!

KorryKatti commented 1 month ago

@KorryKatti I have managed to narrow down the issue and fixed it and pushed the fix to the branch, kindly check it out and let me know if you find any more issues.

Happy Hacking!!

will check and let you know

KorryKatti commented 1 month ago

it works , thanks for the PR

happy coding