KorryKatti / Python-Image-Board

Imageboard with no text only images
http://korrykatti.pythonanywhere.com/
5 stars 5 forks source link

need an imageboard #6

Open KorryKatti opened 8 hours ago

KorryKatti commented 8 hours ago

global.html now works , please make an image board for it , first pr which does it will be accepted,

Remember the data for global imageboard should be stored in a different json file than the thunder one

Abhinavks1405 commented 8 hours ago

I will do it.

KorryKatti commented 8 hours ago

alright assigning you , be sure to test your code before pushing

Abhinavks1405 commented 8 hours ago

I will take care of that.

Shouryan-Bharote commented 5 hours ago

ok i am working on /global i have created 1.form UI for uploading Image 2.functions to upload image 3.created a new json file named "global_images.json"

can u assign me this task

KorryKatti commented 5 hours ago

assigned , be sure the code works fine and you are good to go

Shouryan-Bharote commented 3 hours ago

I have made a PR Please check @KorryKatti

KorryKatti commented 3 hours ago

i will check in a while , bit busy rn

Abhinavks1405 commented 3 hours ago

@KorryKatti i have also made a pr can you check

KorryKatti commented 3 hours ago

@KorryKatti i have also made a pr can you check

checking

KorryKatti commented 3 hours ago

@Shouryan-Bharote : your imageboard redirects to index page and has no password option @Abhinavks1405 : your imageboard doesn't render the latest update popup and displays it as a text in html instead , also the images are very small , they should be large and one below each other like in /thunder

Whoever fixes their issue first will have their PR merged, I am closing the already open PR's for now , make sure to submit a new PR

Shouryan-Bharote commented 3 hours ago

I have checked the thunder page's password field and have failed to recognize its purpose or what the password is for exactly

since we need the same password field in the Global Page Please Clear my Doubt

KorryKatti commented 3 hours ago

I have checked the thunder page's password field and have failed to recognize its purpose or what the password is for exactly

since we need the same password field in the Global Page Please Clear my Doubt

the password field is used by the admin to delete images which are nsfw or potentially bad , so the person who knows the password can delete the image , and by delete the image it removes the entry of the image in the json file.

hope i made it clear

Shouryan-Bharote commented 3 hours ago

I have checked the thunder page's password field and have failed to recognize its purpose or what the password is for exactly since we need the same password field in the Global Page Please Clear my Doubt

the password field is used by the admin to delete images which are nsfw or potentially bad , so the person who knows the password can delete the image , and by delete the image it removes the entry of the image in the json file.

hope i made it clear

Alright I got it so I will make these changes

1.Create The password Field 2.Create The Delete Button 3.RenderTemplate(Global) after Uploading Image or Commenting Image

KorryKatti commented 3 hours ago

I have checked the thunder page's password field and have failed to recognize its purpose or what the password is for exactly since we need the same password field in the Global Page Please Clear my Doubt

the password field is used by the admin to delete images which are nsfw or potentially bad , so the person who knows the password can delete the image , and by delete the image it removes the entry of the image in the json file. hope i made it clear

Alright I got it so I will make these changes

1.Create The password Field 2.Create The Delete Button 3.RenderTemplate(Global) after Uploading Image or Commenting Image

sounds good to me

Abhinavks1405 commented 2 hours ago

@KorryKatti made the changes , please review

KorryKatti commented 2 hours ago

This is now done in #12

KorryKatti commented 2 hours ago

Issue is still open since comments is not working and showing invalid image index and also on submitting a comment its redirecting to index

so well @Shouryan-Bharote you can still improve the code

KorryKatti commented 2 hours ago

image this is what it is looking like right now

Shouryan-Bharote commented 2 hours ago

Thank You @KorryKatti for tagging me again i will continue working on the code

KorryKatti commented 2 hours ago

great

Shouryan-Bharote commented 1 hour ago

@KorryKatti completed the requested changes

KorryKatti commented 1 hour ago

@KorryKatti completed the requested changes

testing now

KorryKatti commented 1 hour ago

Thanks for the work , this issue closes now