Week2 base crud - Githubissues

KorynLA / GuineaPigFactsBackend

Daily guinea pig facts

0 stars 0 forks source link

Week2 base crud #4

Closed KorynLA closed 4 years ago

KorynLA commented 4 years ago

Week 2 work done

KorynLA commented 4 years ago

From code review still need to implement/fix:

[x] Validate parameters
[x] Subtask 1) User Model: id, userName, password email, dailyUpdate
[x] Subtask 2) Fact Model: id, factValue, approved, dateCreated
[x] Use Interfaces for Services
[x] Remove commented code
[x] Update controller routing
[x] Update response status codes
[x] Subtask 1) 404 for when Id is not found
[x] Subtask 2) Update Empty collection so exception is not thrown for FactController & FactService
[x] Update and use JavaDocs comments

KorynLA commented 4 years ago

Spec for Parameter Validation

User Controller

[x] id: determine it is 12 bytes
[x] userName: 4-20 characters. 0-9, all letters both capital and lowercase, and _ are valid.
[x] password: At least 8 characters with at least 1 number.
[x] email: valid email
[x] dailyUpdate: boolean (true / false)

Fact Controller

[x] id: determine it is 12 bytes
[x] factValue: At least 8 characters with 1 space. All characters between ascii decimal values 32-126 will be accepted.
[x] approved: boolean (true / false)
[x] dateCreated: String given in format (Month)00/(Date)00/(Year)0000

rdelhommer commented 4 years ago

let me know when you're ready. looks like you still have a little bit left on your todo list

KorynLA commented 4 years ago

let me know when you're ready. looks like you still have a little bit left on your todo list

@rdelhommer It's ready for review.

Also, I didn't implement path variable validation. If the id passed as the path variable doesn't return a document then it wasn't a valid id. Or is it standard to also have a validation for the path variables?