P2: Feedback - Githubissues

Korysam15 / cs414-f17-301-GenericTeamName

This repository will provide a working solution to implement the game known as Banqi.

3 stars 1 forks source link

P2: Feedback #2

Closed lmorenoc closed 7 years ago

lmorenoc commented 7 years ago

Good job! Next are a few comments to consider in the next iterations:

General comments

Terms in the glossary should be sorted in ascending alphabetical order
The is-a relationship has a special notation (fat triangular arrow from the subclass to the superclass)
How are the pieces of difference players distinguished?
Proofread the glossary

Player

Doesn't a Player own a set of pieces? Maybe an association is missing?

GameStats

What type of attribute are winner and loser? What if there is a draw?

Korysam15 commented 7 years ago

I implemented these changes into the UML Diagram and updated the Glossary. Thanks for the feedback.