Korzer420 / LoreRandomizer

Hollow Knight Mod that adds additional lore checks for Randomizer 4
MIT License
0 stars 0 forks source link

Problem where interactable NPC won't show up in location despite having that dialog level #2

Closed peachdoxie closed 6 months ago

peachdoxie commented 1 year ago

Twice now I've played randos where NPCs won't show up where they should, and both times they've had my progression and I'm unable to continue without using debug or benchwarp and breaking logic. The first was Hornet in Beast's Den and the second one is Quirrel in Deepnest. I suspect it might be because I'm missing certain movement (wings for Hornet, and claw for Quirrel) that would trigger the characters showing up in the right locations, but I'm not sure. I no longer have the logs for the Hornet game but have saved the ones for the Quirrel game if desired.

Korzer420 commented 1 year ago

Hey sorry to hear that.

Could you provide your Modlog, the settings.txt file from that rando as well as your userX.modded.json file?

All of these can be found in the AppData/LocalLow/Team Cherry/Hollow Knight directory (if you are on windows at least, not sure how the path is on other OS).

The rando settings file is in Randomizer 4/Recent folder in that directory, in case that rando where this occured was your last one.

peachdoxie commented 1 year ago

settings.txt ModLog 8-12.txt

Here are the settings file and the modlog. Github won't let me upload the user1.modded.json file, but I am not sure if it is useful anymore since I started a new rando in between submitting this issue and when I got your reply. What would you like me to do about that?

peachdoxie commented 1 year ago

Hi again. I had this same issue once more, where Quirrel in Deepnest didn't spawn and was my only in-logic check. I found the item in the spoiler log and used debug to get to it and continued playing that way. After two more Quirrel levels, I checked back in Deepnest and he was there, so I was able to get the item and continue without using debug. I don't know if this is useful but I thought I'd share what happened.

Korzer420 commented 1 year ago

Hey, I couldn't reproduce the issue. I could add some kind of backup system that places a shiny there, although this might take a few days.

In case you do another attempt and encounter this issue please provide the location as well as the level of that traveller. If this doesn't occur with the higher level like you mentioned maybe there is a problem in the logic order. Either way you can modify the savedata to increase the traveller level to force the npc to appear (if that's the solution).

peachdoxie commented 1 year ago

Thank you for the solution if this occurs again.

I went back through my tracker log and found the order in which I visited Quirrel and found his dialog, which I think is what you're asking for.

If they're relevant, here's the rest of them:

Korzer420 commented 6 months ago

@peachdoxie Hey, sorry for the late response. Was quite busy the last few months. I think I found the issue, the order in logic doesn't match the actual order in the code (at least for the Quirrel example, I'll review the other onces as well). I'll release an update in the next few days

Korzer420 commented 6 months ago

Fixed in LoreRando 0.3 (+ LoreCore 0.6)

(Hornet had a different issue btw but this is fixed now)