search

Kosar-projects / HW1

0 stars 0 forks source link

review #1

Open JKarimi12 opened 4 weeks ago

JKarimi12 commented 4 weeks ago

.gitignore?

JKarimi12 commented 4 weeks ago

rm venv, pycache, db.sqlite, ...

JKarimi12 commented 4 weeks ago

bank_system

JKarimi12 commented 4 weeks ago

https://github.com/Kosar-projects/HW1/blob/0a947312913c69168fd42b0bb9a8ff1ce915a0cb/banksystem/people/models.py#L12

شاید charfield بهتر می‌بود.

JKarimi12 commented 4 weeks ago

https://github.com/Kosar-projects/HW1/blob/0a947312913c69168fd42b0bb9a8ff1ce915a0cb/banksystem/query.py#L62 بهتر بود print ساده می‌ذاشتید به جای این کارها. و logهای خروجی رو داخل فایل می‌ذاشتید.

JKarimi12 commented 4 weeks ago

https://github.com/Kosar-projects/HW1/blob/0a947312913c69168fd42b0bb9a8ff1ce915a0cb/banksystem/query.py#L68 باید توی transaction می‌بود.

JKarimi12 commented 4 weeks ago

requirements.txt?