search

KosherJava / zmanim

KosherJava Zmanim API / Library
https://kosherjava.com
GNU Lesser General Public License v2.1
107 stars 49 forks source link

Change README gradle import syntax #197

Open Sternbach-Software opened 1 year ago

Sternbach-Software commented 1 year ago

Replace implementation group: 'com.kosherjava', name: 'zmanim', version: '2.4.0' with implementation 'com.kosherjava:zmanim:2.4.0

elijulian commented 1 year ago

I think that this is a matter of taste, if you prefer this syntax maybe open a pull request to change it

elijulian commented 1 year ago

Definitely not a bug

Sternbach-Software commented 1 year ago

@elijulian Seems to cause bugs: https://github.com/KosherJava/zmanim/issues/198#issuecomment-1334082086

elfifo4 commented 1 year ago

Hi @elijulian it's not just a matter of taste in build.gradle.kts of KMM project (Kotlin Multiplatform Mobile), it doesn't compile. so this syntax is really needed: implementation("com.kosherjava:zmanim:2.5.0")

relevant PR: https://github.com/KosherJava/zmanim/pull/210

Screen Shot 2023-06-26 at 15 42 10
elijulian commented 1 year ago

Hi @elijulian it's not just a matter of taste in build.gradle.kts of KMM project (Kotlin Multiplatform Mobile), it doesn't compile. so this syntax is really needed: implementation("com.kosherjava:zmanim:2.5.0")

relevant PR: #210

Screen Shot 2023-06-26 at 15 42 10

fascinating, i didn't realize that it was required by any platform.