KosherJava / zmanim

KosherJava Zmanim API / Library
https://kosherjava.com
GNU Lesser General Public License v2.1
107 stars 49 forks source link

Spelling errors #215

Open Sternbach-Software opened 1 year ago

Sternbach-Software commented 1 year ago

Why does rosh hashana(h) have two different spellings? (Seems reminiscent of #213) Same for Suk(k)ah, Kesub(v)os, Ta(')anis, Megil(l)ah, Kidushin, Horayos, Bava Kama, Makos, Nidah. https://github.com/KosherJava/zmanim/blob/bca6ddb85542683f229d905636a06fbfc66fbe03/src/main/java/com/kosherjava/zmanim/hebrewcalendar/Daf.java#L39 https://github.com/KosherJava/zmanim/blob/bca6ddb85542683f229d905636a06fbfc66fbe03/src/main/java/com/kosherjava/zmanim/hebrewcalendar/Daf.java#L70

And while I am at it may I add that:

Although the user can change it, I think the defaults should make sense. Maybe an official transliteration policy? (I personally have an extreme and clearly articulated opinion on transliteration, but I think it at least lays out the edge cases. Rules 10 and 13 there would solve the inconsistency between Tfila and Rosh Hashanah/Avodah Zarah)