search

Kosinkadink / ComfyUI-Advanced-ControlNet

ControlNet scheduling and masking nodes with sliding context support
GNU General Public License v3.0
547 stars 54 forks source link

SparseCtrl/experimental is awesome, what is its status? #151

Open aihopper opened 1 month ago

aihopper commented 1 month ago

This module https://github.com/Kosinkadink/ComfyUI-Advanced-ControlNet/blame/68e5cd41e43cf0ec0a052167ef2c1c1bfb3aac7d/adv_control/nodes_sparsectrl.py#L69 i believe takes a controlnet(i.e: ) and converts it into a sparsectrl, this is gold!

What is its status?

In order to use it I had to remove motion_holder from https://github.com/Kosinkadink/ComfyUI-Advanced-ControlNet/blame/68e5cd41e43cf0ec0a052167ef2c1c1bfb3aac7d/adv_control/nodes_sparsectrl.py#L84

Should I expect correct results?

edit: OK it looks like this needs some more fixes that I am still trying to figure out, but any help is welcome! :)

Kosinkadink commented 1 month ago

This was an experimental feature to see if there was any possible utility in using normal controlnet weights alongside the motion modules contained in SparseCtrl models, but all experimentation by me and other peeps in the community only produced god awful results, not sure you could even call it "working".

I wasn't aware that the node stopped working though. I'll look into it at some point to get it working again, if its broken currently.

aihopper commented 2 weeks ago

(back from vacation, sorry for the delay) I very much appreciate your update as this saved me a lot of time trying to make it work. It looked like a good approach.