search

Kosinkadink / ComfyUI-Advanced-ControlNet

ControlNet scheduling and masking nodes with sliding context support
GNU General Public License v3.0
622 stars 60 forks source link

LLLite CNs don't work correctly with Hotshot #74

Open sjuxax opened 9 months ago

sjuxax commented 9 months ago

I haven't had any success using ControlNet-LLLite CNs together with Hotshot. It just turns into a bunch of junk. The same CNs work well without the motion module. I haven't tested with ADXL.

Kosinkadink commented 9 months ago

Can you give example of which ControlLLLITE models you've tried? During development I tried out canny and lineart with Hotshot, and those worked as expected.

sjuxax commented 8 months ago

https://huggingface.co/bdsqlsz/qinglong_controlnet-lllite/blob/main/bdsqlsz_controlllite_xl_normal.safetensors is one example -- this works for single images, but not with AD.

Kosinkadink commented 8 months ago

I had someone try it out, and it worked fine with Hotshot on their end. Can you post a screenshot of a basic workflow where it doesn't work for you?

kijai commented 8 months ago

Working ok here, did a quick test: https://github.com/Kosinkadink/ComfyUI-Advanced-ControlNet/assets/40791699/5dbacbfa-c9c7-4c48-a5df-030aed341e84

sjuxax commented 8 months ago

So I troubleshot with @kijai in Discord and found it's a resolution thing. If I use a resolution divisible by 32 on both width and height (896x512 in this case), things work well. If I don't (was using 872x500), I get junky output like this: 2024-03-04_01-40-49, which needless to say, doesn't match the normal map I was feeding in.

Maybe there should be a resolution warning when using LLLite CNs with incompatible resolutions, or some internal rounding to prevent this? Not sure on a good way to resolve smoothly.