Kosinkadink / ComfyUI-Advanced-ControlNet

ControlNet scheduling and masking nodes with sliding context support
GNU General Public License v3.0
559 stars 56 forks source link

can not bypass controlnet #90

Closed bihailantian655 closed 6 months ago

bihailantian655 commented 6 months ago

workflow (6) workflow (5)

the only difference between these two pic is whether or not to bypass a cnet group . here is one more pic

workflow (7)

I don't think this is a fault with [rgthree-comfy] , but I am unsure who to report this issue to.

bihailantian655 commented 6 months ago

It seems that bypassing the cnet still affects the generated images, causing them to become blurry.

Kosinkadink commented 6 months ago

I have no custom JavaScript in this repo, so the bug of bypass not working is due to something else. I've never had any problem with bypass if I do vanilla ComfyUI bypass.

bihailantian655 commented 6 months ago

workflow (8)

but ctrl +b get same result ,

Kosinkadink commented 6 months ago

Might be a weird .js issue with grouped nodes (that cnet node does not look like it's individual, it looks like the two nodes merged into one)

Kosinkadink commented 6 months ago

Either way, nothing I can do about it, it's a bug somewhere else. The CNs you're loading are basic controlnet types from the looks of it, so they should work as intended. Bypassing not working is a JavaScript problem, and since I do no JavaScript in this repo, it can't be an issue with the nodes here.

Kosinkadink commented 6 months ago

There is a bug in comfy currently with nodes merged into one not always properly respecting the positive/negative conditioning, so this might be related to that. Try it with no merged nodes.

bihailantian655 commented 6 months ago

by using advanced cnet have no such issue(from the progress bar i can see the preview image ). but i dont know why the second sampler can not preview image

workflow (9) weird weird

bihailantian655 commented 6 months ago

forget connect vae t the second sampler

thanks again