Kosinkadink / ComfyUI-Advanced-ControlNet

ControlNet scheduling and masking nodes with sliding context support
GNU General Public License v3.0
617 stars 61 forks source link

Advanced-ControlNet inpaint not working ? #91

Closed bihailantian655 closed 8 months ago

bihailantian655 commented 8 months ago

workflow (1)

The difference between these two workflows is that the first uses native Control Net , the second use ADV controlnet , and it seems that ADV inpaint has very little impact.

Maybe it's because I'm not using adv cnet correctly,

workflow

Kosinkadink commented 8 months ago

The mask_optional parameter on advanced ControlNet is not an inpaint mask, it is an attention mask for where ControlNet should take effect (and how much, meaning gradients are allowed). Your setup with the preprocessor, etc still needs to be the same as with vanilla nodes.

bihailantian655 commented 8 months ago

workflow (2)

Kosinkadink commented 8 months ago

To reiterate, the mask_optional input on Apply Advanced ControlNet has nothing to do with inpaint or inpaint controlnet. You still have to use the preprocessor same as before. You don't need to plug anything into mask_optional unless you intend to mask the controlnet's effects.

bihailantian655 commented 8 months ago

workflow (4)

do you mean like this

Kosinkadink commented 8 months ago

Yes, but you're missing the inpaint preprocessor for the control net, which you had set up correctly for your vanilla controlnet example in your original post.

bihailantian655 commented 8 months ago

This time it should be right, thank you again for your help

Kosinkadink commented 8 months ago

No problem!

bihailantian655 commented 8 months ago

ComfyUI_02520_