search

Kosinkadink / ComfyUI-AnimateDiff-Evolved

Improved AnimateDiff for ComfyUI and Advanced Sampling Support
Apache License 2.0
2.76k stars 208 forks source link

Recent commit makes many nodes unable to be added from Add Node menu or Search #417

Closed rgthree closed 4 months ago

rgthree commented 4 months ago

It seems that https://github.com/Kosinkadink/ComfyUI-AnimateDiff-Evolved/commit/275e95147fb7902d9ef17770dba8878d857081b6 breaks any virtual node.

Raised for rgthree-comfy (See: https://github.com/rgthree/rgthree-comfy/issues/269) which uses a lot of virtual nodes, but also happens for many other nodes like the ComfyUI default Reroute and Note nodes.

It seems to have to do with adding the filter to nodes in the beforeRegisterNode which virtual nodes don't go through, making them inaccessible. Hopefully there's a better way to hide/show ADE nodes without setting/affecting other nodes?

Kosinkadink commented 4 months ago

Thank you for the report, I apologize for the trouble and hopefully the hiding works as intended now with Austin's fix. If it does not, we will just completely remove that addition in the next pushed version and go back to the drawing board.