search

Kosinkadink / ComfyUI-AnimateDiff-Evolved

Improved AnimateDiff for ComfyUI and Advanced Sampling Support
Apache License 2.0
2.62k stars 194 forks source link

The new "View" options do not work with fuse_methods that require sigma #475

Open Quasimondo opened 1 week ago

Quasimondo commented 1 week ago

Unlike the regular context handler It looks like the new view handler does not pass the optional "sigma" argument to the get_context_weights() method which causes an error for those option that require sigma.

Kosinkadink commented 1 week ago

Can you point me to the code? I don't think I've modified view options code in a few months, so I'm not sure what you mean by new view options

Quasimondo commented 1 week ago

Ah sorry, maybe they are not that new anymore (I was on holiday for the past weeks) - I am referring to these: image

Kosinkadink commented 1 week ago

Ah, do the sigma related fuse methods only work on ContextOptions and not View Options?

Quasimondo commented 1 week ago

Yes, that's what I am seeing here.

Kosinkadink commented 1 week ago

I should have time to implement the required changes at the end of September/beginning of October. Apologies for the delay, I am currently spending time on some core ComfyUI code, but by the end of that AnimateDiff-Evolved and Advanced-ControlNet will be able to have a cleaner codebase and new potential for features across all of ComfyUI custom nodes.

However, I think the changes required here should be simple though, as the timestep sigma would just need to be passed into somewhere from transformer_options. If you can find the changes required for context.py code to get that val for View Options, I can make a quick patch for it sometime this week.

Quasimondo commented 1 week ago

Okay, thanks for the pointers - I'll dig around in those transformer_options and maybe I can find the right place where to pass the sigmas.