[Feature Request] iterative video combine to prevent oom

Kosinkadink / ComfyUI-VideoHelperSuite

Nodes related to video workflows

GNU General Public License v3.0

513 stars 90 forks source link

[Feature Request] iterative video combine to prevent oom #140

Closed qqqllppp closed 7 months ago

qqqllppp commented 7 months ago

When I try to combine video at higher resolutions or a lot of frames, I get OOM (Out Of Memory) error.

Is it possible to do a form of iterative video combine process so to not run into OOM?

AustinMroz commented 7 months ago

The recommendation up to now has been to manually queue multiple executions with skip_first_frames and frame_load_cap, but this is inconvenient and doesn't provide a way to merge the results together.

I agree that this is functionality that should exist and have begun work on implementing it.

AustinMroz commented 7 months ago

I have a functional proof of concept which I have pushed to a new batch_manager branch. While I'm rather pleased with the results, it'll need a good bit of testing for edge cases and currently only functions with a single Load Video and a single Video Combine.

qqqllppp commented 7 months ago

nice! cant wait for it to be deployed :)