search

Kosinkadink / ComfyUI-VideoHelperSuite

Nodes related to video workflows
GNU General Public License v3.0
543 stars 95 forks source link

Is this node mac compliant? getting: "TypeError: expected str, bytes or os.PathLike object, not NoneType" on MacOs Ventura. #156

Open bkmikaelo7 opened 7 months ago

bkmikaelo7 commented 7 months ago

Hello, I'm getting the following error (last lines) :

"File "", line 152, in dirname TypeError: expected str, bytes or os.PathLike object, not NoneType"

Might be an issue with my Comfy/Python/Conda version/installation also, but I was just wondering if it's because of some in-discrepancy between windows and mac os way of structuring file pathnames ?

I'm on Intel x86, Mac Os Ventura, and the drive I attempt to load images from is Journaled HFS+.

--- the error as a whole

Traceback (most recent call last): File "/Users/finalcountdown/opt/anaconda3/envs/comfy/lib/python3.11/site-packages/aiohttp/web_protocol.py", line 452, in _handle_request resp = await request_handler(request) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/finalcountdown/opt/anaconda3/envs/comfy/lib/python3.11/site-packages/aiohttp/web_app.py", line 543, in _handle resp = await handler(request) ^^^^^^^^^^^^^^^^^^^^^^ File "/Users/finalcountdown/opt/anaconda3/envs/comfy/lib/python3.11/site-packages/aiohttp/web_middlewares.py", line 114, in impl return await handler(request) ^^^^^^^^^^^^^^^^^^^^^^ File "/Volumes/1/Users/BS/SD/ComfyUI-new/server.py", line 47, in cache_control response: web.Response = await handler(request) ^^^^^^^^^^^^^^^^^^^^^^ File "/Volumes/1/Users/BS/SD/ComfyUI-new/custom_nodes/ComfyUI-VideoHelperSuite/videohelpersuite/server.py", line 111, in view_video with subprocess.Popen(args, stdout=subprocess.PIPE) as proc: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/finalcountdown/opt/anaconda3/envs/comfy/lib/python3.11/subprocess.py", line 1022, in init self._execute_child(args, executable, preexec_fn, close_fds, File "/Users/finalcountdown/opt/anaconda3/envs/comfy/lib/python3.11/subprocess.py", line 1773, in _execute_child and os.path.dirname(executable) ^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "", line 152, in dirname TypeError: expected str, bytes or os.PathLike object, not NoneType

AustinMroz commented 7 months ago

Since the executable itself is None, it's probably imageio-ffmpeg not being installed(/Conda related). There's probably an error message about ffmpeg not being found if you scroll up in the console. I'm able to replicate the exact error message when ffmpeg is not found and Advanced Previews is enabled.

We fully intend for Mac Os to be supported. While it's possible that errors could crop up since I'm only able to test Linux and Windows, I'm reasonably confident it isn't the case here.