search

Kosinkadink / ComfyUI-VideoHelperSuite

Nodes related to video workflows
GNU General Public License v3.0
434 stars 76 forks source link

useless set loop_count in Video Combine #170

Open anyshu opened 4 months ago

anyshu commented 4 months ago

maybe this code is wrong, in nodes.py

截屏2024-03-18 18 34 36
AustinMroz commented 4 months ago

It certainly looks strange, but the first loop is the name of the filter and the second loop is a named setting for the loop filter, see the ffmpeg documentation for loop.

On a tangentially related note, this loop filter is currently applied even when loop_count is 0 which is subideal. It's easy to conditionally apply it as in 0391ddf, but I'm actively investigating alternatives that are compatible with the recent memory optimizations I've been working on.