Kosinkadink / ComfyUI-VideoHelperSuite

Nodes related to video workflows
GNU General Public License v3.0
627 stars 102 forks source link

ComfyUI Update - 5th Apr 2024 Error #187

Open dustyninja opened 7 months ago

dustyninja commented 7 months ago

Hi, I think may people have been affect from yesterday's ComfyUI update from 5th April 2024. The update has caused my Video Helper to stop working.

Below is the log. I would really appreciate if someone can look into this (I can't read code)

Log:

Error occurred when executing VHS_LoadVideoPath:

"D:\ComfyUI_windows_portable\ComfyUI\output\AnimationMK_00034.mp4" could not be loaded with cv.

File "D:\ComfyUI_windows_portable\ComfyUI\execution.py", line 151, in recursive_execute output_data, output_ui = get_output_data(obj, input_data_all) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "D:\ComfyUI_windows_portable\ComfyUI\execution.py", line 81, in get_output_data return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "D:\ComfyUI_windows_portable\ComfyUI\execution.py", line 74, in map_node_over_list results.append(getattr(obj, func)(slice_dict(input_data_all, i))) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-VideoHelperSuite\videohelpersuite\load_video_nodes.py", line 252, in load_video return load_video_cv(kwargs) ^^^^^^^^^^^^^^^^^^^^^^^ File "D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-VideoHelperSuite\videohelpersuite\load_video_nodes.py", line 126, in load_video_cv (width, height, fps, duration, total_frames, target_frame_time) = next(gen) ^^^^^^^^^ File "D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-VideoHelperSuite\videohelpersuite\load_video_nodes.py", line 50, in cv_frame_generator raise ValueError(f"{video} could not be loaded with cv.")

AustinMroz commented 7 months ago

Tested in a fresh venv to be sure, but I'm still not able to reproduce this. As the error itself is from opencv being unable to load the video after being given a path that has been checked for validity, it's awfully unlikely there's a problem in the loading code. Additionally, given the path of the video file, it's probably produced by us and should be valid.

Can you

Kosinkadink commented 7 months ago

Also, if possible, could you attach the video that is giving you trouble? We had someone in the last few weeks report something similar, but whether it was due to a language barrier or otherwise, we were not able to get them to give us a video file that caused the issue.

dustyninja commented 7 months ago

Hello, The video can be opened with a media player

This is the console feed below:

D:\ComfyUI_windows_portable>.\python_embeded\python.exe -s ComfyUI\main.py --windows-standalone-build ComfyUI startup time: 2024-04-06 20:31:56.841147 Platform: Windows Python version: 3.11.6 (tags/v3.11.6:8b6ee5b, Oct 2 2023, 14:57:12) [MSC v.1935 64 bit (AMD64)] Python executable: D:\ComfyUI_windows_portable\python_embeded\python.exe ** Log path: D:\ComfyUI_windows_portable\comfyui.log

Prestartup times for custom nodes: 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\rgthree-comfy 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Marigold 0.2 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Manager

Total VRAM 8191 MB, total RAM 32703 MB Set vram state to: NORMAL_VRAM Device: cuda:0 NVIDIA GeForce RTX 3070 : cudaMallocAsync VAE dtype: torch.bfloat16 Using pytorch cross attention Adding extra search path checkpoints D:/stable-diffusion/stable-diffusion-webui\models/Stable-diffusion Adding extra search path configs D:/stable-diffusion/stable-diffusion-webui\models/Stable-diffusion Adding extra search path vae D:/stable-diffusion/stable-diffusion-webui\models/VAE Adding extra search path loras D:/stable-diffusion/stable-diffusion-webui\models/Lora Adding extra search path loras D:/stable-diffusion/stable-diffusion-webui\models/LyCORIS Adding extra search path upscale_models D:/stable-diffusion/stable-diffusion-webui\models/ESRGAN Adding extra search path upscale_models D:/stable-diffusion/stable-diffusion-webui\models/RealESRGAN Adding extra search path upscale_models D:/stable-diffusion/stable-diffusion-webui\models/SwinIR Adding extra search path embeddings D:/stable-diffusion/stable-diffusion-webui\embeddings Adding extra search path hypernetworks D:/stable-diffusion/stable-diffusion-webui\models/hypernetworks Adding extra search path controlnet D:/stable-diffusion/stable-diffusion-webui\extensions\sd-webui-controlnet\models Adding D:\ComfyUI_windows_portable\ComfyUI\custom_nodes to sys.path Efficiency Nodes: Attempting to add Control Net options to the 'HiRes-Fix Script' Node (comfyui_controlnet_aux add-on)...Success! Loaded efficiency nodes from D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\efficiency-nodes-comfyui Loaded ControlNetPreprocessors nodes from D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui_controlnet_aux [Errno 2] No such file or directory: 'D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Advanced-ControlNet\control/control.py\init.py' Could not find AnimateDiff nodes Loaded IPAdapter nodes from D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_IPAdapter_plus metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases Loaded VideoHelperSuite from D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-VideoHelperSuite Note: NumExpr detected 12 cores but "NUMEXPR_MAX_THREADS" not set, so enforcing safe limit of 8. NumExpr defaulting to 8 threads.

Loading: ComfyUI-Impact-Pack (V4.87)

Loading: ComfyUI-Impact-Pack (Subpack: V0.4)

Loading: ComfyUI-Inspire-Pack (V0.69.3)

[Impact Pack] Wildcards loading done.

Loading: ComfyUI-Manager (V2.15)

ComfyUI Revision: 2114 [de172f8b] | Released on '2024-04-06'

[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/alter-list.json D:\ComfyUI_windows_portable\python_embeded\Lib\site-packages\diffusers\utils\outputs.py:63: UserWarning: torch.utils._pytree._register_pytree_node is deprecated. Please use torch.utils._pytree.register_pytree_node instead. torch.utils._pytree._register_pytree_node( [ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/model-list.json [ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/extension-node-map.json Failed to auto update Quality of Life Suit QualityOfLifeSuit_Omar92_DIR: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-QualityOfLifeSuit_Omar92

Comfyroll Studio v1.76 : 175 Nodes Loaded

For changes, please see patch notes at https://github.com/Suzie1/ComfyUI_Comfyroll_CustomNodes/blob/main/Patch_Notes.md For help, please see the wiki at https://github.com/Suzie1/ComfyUI_Comfyroll_CustomNodes/wiki

FizzleDorf Custom Nodes: Loaded [ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/custom-node-list.json [tinyterraNodes] Loaded Skip D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\HighResFix.py module for custom nodes due to the lack of NODE_CLASS_MAPPINGS. Downloading anime face detector... Failed to download lbpcascade_animeface.xml so please download it in D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\IPAdapter-ComfyUI.

[rgthree] Loaded 36 exciting nodes.

WAS Node Suite: OpenCV Python FFMPEG support is enabled WAS Node Suite Warning: ffmpeg_bin_path is not set in D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\was-node-suite-comfyui\was_suite_config.json config file. Will attempt to use system ffmpeg binaries if available. WAS Node Suite: Finished. Loaded 211 nodes successfully.

    "Opportunities don't happen. You create them." - Chris Grosser

Import times for custom nodes: 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\efficiency-nodes-comfyui 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_IPAdapter_plus 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-VideoHelperSuite 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\canvas_tab 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Image-Selector 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\websocket_image_save.py 0.0 seconds (IMPORT FAILED): D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\HighResFix.py 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Logic 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Embedding_Picker 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUi_PromptStylers 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui_controlnet_aux 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\masquerade-nodes-comfyui 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\sd-dynamic-thresholding 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\stability-ComfyUI-nodes 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_essentials 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_experiments 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-QualityOfLifeSuit_Omar92 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_FizzNodes 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\IPAdapter-ComfyUI 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Custom-Scripts 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfy-image-saver 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_UltimateSDUpscale 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Frame-Interpolation 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Advanced-ControlNet 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-JDCN 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\Derfuu_ComfyUI_ModdedNodes 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\rgthree-comfy 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_Comfyroll_CustomNodes 0.0 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\facerestore_cf 0.1 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Impact-Pack 0.1 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Inspire-Pack 0.2 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Marigold 0.2 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AudioScheduler 0.4 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Manager 0.4 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\clipseg.py 0.6 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-art-venture 0.7 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_tinyterraNodes 4.1 seconds: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\was-node-suite-comfyui

Starting server

To see the GUI go to: http://127.0.0.1:8188 FETCH DATA from: D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Manager\extension-node-map.json Error: OpenAI API key is invalid OpenAI features wont work for you QualityOfLifeSuit_Omar92::NSP ready got prompt !!! Exception during processing !!! Traceback (most recent call last): File "D:\ComfyUI_windows_portable\ComfyUI\execution.py", line 151, in recursive_execute output_data, output_ui = get_output_data(obj, input_data_all) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "D:\ComfyUI_windows_portable\ComfyUI\execution.py", line 81, in get_output_data return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "D:\ComfyUI_windows_portable\ComfyUI\execution.py", line 74, in map_node_over_list results.append(getattr(obj, func)(slice_dict(input_data_all, i))) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-VideoHelperSuite\videohelpersuite\load_video_nodes.py", line 252, in load_video return load_video_cv(kwargs) ^^^^^^^^^^^^^^^^^^^^^^^ File "D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-VideoHelperSuite\videohelpersuite\load_video_nodes.py", line 126, in load_video_cv (width, height, fps, duration, total_frames, target_frame_time) = next(gen) ^^^^^^^^^ File "D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-VideoHelperSuite\videohelpersuite\load_video_nodes.py", line 50, in cv_frame_generator raise ValueError(f"{video} could not be loaded with cv.") ValueError: "D:\ComfyUI_windows_portable\ComfyUI\output\AnimationMK_00034.mp4" could not be loaded with cv.

Prompt executed in 0.01 seconds

dustyninja commented 7 months ago

Hi,

Just wondering if anyone has come across this issue? For me it happened right after I updated ComfyUI on 05 Apr 2024

melMass commented 7 months ago

I'm pretty sure it's unrelated to comfy's update, the error is about opencv not able to open your given mp4:

ValueError(f"{video} could not be loaded with cv.")

Can you try various videos ? like truck

Related issues:

dustyninja commented 7 months ago

Hi, I've tried the video suggested in the previous thread but sadly no luck

Here is the message: Error occurred when executing VHS_LoadVideoPath:

"C:\Users\Mostafa\Downloads\truck.mp4" could not be loaded with cv.

File "D:\ComfyUI_windows_portable\ComfyUI\execution.py", line 151, in recursive_execute output_data, output_ui = get_output_data(obj, input_data_all) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "D:\ComfyUI_windows_portable\ComfyUI\execution.py", line 81, in get_output_data return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "D:\ComfyUI_windows_portable\ComfyUI\execution.py", line 74, in map_node_over_list results.append(getattr(obj, func)(slice_dict(input_data_all, i))) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-VideoHelperSuite\videohelpersuite\load_video_nodes.py", line 252, in load_video return load_video_cv(kwargs) ^^^^^^^^^^^^^^^^^^^^^^^ File "D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-VideoHelperSuite\videohelpersuite\load_video_nodes.py", line 126, in load_video_cv (width, height, fps, duration, total_frames, target_frame_time) = next(gen) ^^^^^^^^^ File "D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-VideoHelperSuite\videohelpersuite\load_video_nodes.py", line 50, in cv_frame_generator raise ValueError(f"{video} could not be loaded with cv.")

Here is the console steps:

!!! Exception during processing !!! Traceback (most recent call last): File "D:\ComfyUI_windows_portable\ComfyUI\execution.py", line 151, in recursive_execute output_data, output_ui = get_output_data(obj, input_data_all) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "D:\ComfyUI_windows_portable\ComfyUI\execution.py", line 81, in get_output_data return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "D:\ComfyUI_windows_portable\ComfyUI\execution.py", line 74, in map_node_over_list results.append(getattr(obj, func)(slice_dict(input_data_all, i))) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-VideoHelperSuite\videohelpersuite\load_video_nodes.py", line 252, in load_video return load_video_cv(kwargs) ^^^^^^^^^^^^^^^^^^^^^^^ File "D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-VideoHelperSuite\videohelpersuite\load_video_nodes.py", line 126, in load_video_cv (width, height, fps, duration, total_frames, target_frame_time) = next(gen) ^^^^^^^^^ File "D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-VideoHelperSuite\videohelpersuite\load_video_nodes.py", line 50, in cv_frame_generator raise ValueError(f"{video} could not be loaded with cv.") ValueError: "C:\Users\Mostafa\Downloads\truck.mp4" could not be loaded with cv.

Prompt executed in 0.00 seconds

Thebatefly commented 7 months ago

Can you tell me what kind of solution has been found?

melMass commented 7 months ago

Can you tell me what kind of solution has been found?

Can you try the Upload variant of the Video Load node? That will help narrow the issue

ma-gu commented 7 months ago

I had the same issue, updating ComfyUI-VideoHelperSuite with "git pull" to the latest resolved it. Not sure if it helps for portable installation though.

lintengya commented 6 months ago

i have resolve this problem please check your url do not contain Double quotation marks “”

zhaoqf-cq commented 5 months ago

I had the same issue, updating ComfyUI-VideoHelperSuite with "git pull" to the latest resolved it. Not sure if it helps for portable installation though. I also updated ComfyUI-VideoHelperSuite, but the following error occurred:

2024-06-29 18:35:12,576- root:451- INFO- got prompt 2024-06-29 18:35:12,599- root:179- ERROR- !!! Exception during processing!!! 'video' 2024-06-29 18:35:12,599- root:180- ERROR- Traceback (most recent call last): File "C:\Users\13725\Desktop\ComfyUI_windows_portable\ComfyUI\execution.py", line 151, in recursive_execute output_data, output_ui = get_output_data(obj, input_data_all) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\Users\13725\Desktop\ComfyUI_windows_portable\ComfyUI\execution.py", line 81, in get_output_data return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\Users\13725\Desktop\ComfyUI_windows_portable\ComfyUI\execution.py", line 74, in map_node_over_list results.append(getattr(obj, func)(**slice_dict(input_data_all, i))) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\Users\13725\Desktop\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-VideoHelperSuite\videohelpersuite\load_video_nodes.py", line 254, in load_video kwargs['video'] = folder_paths.get_annotated_filepath(strip_path(kwargs['video']))


KeyError: 'video'
O-O1024 commented 1 month ago

I think the bug is from cv2. image