AustinMroz
commented
2 months ago It's always a delight to see your continued contributions. I don't consider myself experienced in javascript either, so it makes it all the more commendable to wade through code that probably isn't the most legible.
The only potential issue I see that makes a functional difference is the manual selection for imageio-ffmpeg which sidesteps all the selection logic/user overrides. Were you seeing some issue with the default ffmpeg selection/ it's usage in get_audio()?
And some minor notes that don't make any functional difference:
- The convDict is only used for migrating old workflows and should never apply to this node.
- The onNodeCreated callback on the other upload nodes is to update previews which the audio nodes don't have.
- The IS_CHANGED and VALIDATE_INPUTS methods are never called because it's only use is as an optional input. I prefer to have them included for correctness/future changes, but it gave me quite a bit of headache when testing the Load Audio (Path).
kijai
Adds a node to allow audio file upload in same way as video upload. I find this necessary when working remotely with audio stuff, and in my opinion it easily integrates here.
Tested to be working with .mp3, .wav and .ogg from Firefox on Linux.
Still not 100% sure of all the javascript stuff especially, I don't have much js experience at all, so @AustinMroz if you could check if there's something missing or if I made a mistake.