search

Kosinkadink / ComfyUI-VideoHelperSuite

Nodes related to video workflows
GNU General Public License v3.0
543 stars 95 forks source link

Video combine frame rate is now FLOAT, but video loader force rate is INT. #193

Open RangerFrank opened 5 months ago

RangerFrank commented 5 months ago

Video combine frame rate is now FLOAT, but video loader force rate is INT.

AustinMroz commented 5 months ago

I was aware of this discrepency when the change was made, but wanted to minimize potential breaking changes at the time and figured that using video_info -> Video Info (Loaded) -> fps -> Video Combine would be a more correct pathway (in handling the edge cases like select_every_nth).

I see no issue with changing force_rate on the Load Video nodes if there's desire for it.