search

Kosinkadink / ComfyUI-VideoHelperSuite

Nodes related to video workflows
GNU General Public License v3.0
543 stars 95 forks source link

feat: ✨ add empty input support #197

Closed melMass closed 5 months ago

melMass commented 5 months ago

Hey Kosink,

This PR simply adds a safe bail for empty IMAGE input. I use this trick with Batch From History you can test a basic sample of the issue here

Kosinkadink commented 5 months ago

@AustinMroz would there be any consequences for this behavior with the way our code is set up? If not, then I think we can merge this in

AustinMroz commented 5 months ago

This looks super neat.

Only potential issue I see is it breaking the best effort support for nodes that output a list of tensors instead of a tensor. (#176)

melMass commented 5 months ago

Oh good point! I'm still not used to comfy's list concept. Let me add an isisntance clause it shouldn't "cost" a lot.

melMass commented 5 months ago

I pushed the fix, let me know if there is any issue left.

Attached is a workflow to test it: test_for_197

instructions

image

output

https://github.com/Kosinkadink/ComfyUI-VideoHelperSuite/assets/7041726/957ca200-4de9-47c1-9bbb-03886b7680dc

AustinMroz commented 5 months ago

The images input should always be a tensor. I consider it a bug of whatever other node is sending a list, but would like to avoid breaking peoples workflows where possible. Looks good to merge.

melMass commented 5 months ago

Thanks!