search

Kosinkadink / ComfyUI-VideoHelperSuite

Nodes related to video workflows
GNU General Public License v3.0
543 stars 95 forks source link

Request: Adding al node name Load audio (Upload) #209

Open ShmuelRonen opened 4 months ago

ShmuelRonen commented 4 months ago

It can be very useful if Load audio (Upload) node will be added to Video-Helper-Suite that will allow the user's to upload audio files directly from the file system.

AustinMroz commented 4 months ago

This was already added. (#192 )

ShmuelRonen commented 4 months ago

This was already added. (#192 )

Not find it...

not

AustinMroz commented 4 months ago

Are you still unable to see the Load Audio (Upload) node after performing a hard refresh with ctrl+F5?

piratex123 commented 4 months ago

Load audio node just will not work!! And it is the only node ever to completely lock up ComfyUI, requiring a restart. It gets stuck at 67 percent and you cannot clear the Queue, I have never seen that before. I don't like to complain about free stuff!! but totally locking up Comfy? I have tried all sorts of audio formats, every video output format, just does not work.

ShmuelRonen commented 4 months ago

Are you still unable to see the Load Audio (Upload) node after performing a hard refresh with ctrl+F5?

No. I was looking at the code and not find it there also.

AustinMroz commented 4 months ago

For Shmuel, if you do not have the code for the Load Audio (Upload) node, it's very likely that some mistake was made when updating and you are not actually on the latest version. Double check you are on the main branch and know you can always do a complete reinstall if needed.

For piratex123, it sounds like you're experiencing an unrelated problem and I would recommend opening a new issue. I've not been able to reproduce the problem you describe and would appreciate additional information. In particular, there's no progress bar on our Load Audio node and I would appreciate confirmation that the lockup occurs when Load Audio is executing. To make a wild guess: Your description sounds like thrashing. Open up the task manager and double check that you aren't out of memory.

ShmuelRonen commented 4 months ago

Thanks for the referral. Interesting that it wasn't picked up when I did a git pull. There is something strange about the interface of Load Audio (Upload). I would have expected a button called 'choose audio to upload' because by clicking on 'audio' it refers to a certain folder that I don't understand why it chose. When I don't find an option to search other folders. load audio upload