Kosinkadink / ComfyUI-VideoHelperSuite

Nodes related to video workflows
GNU General Public License v3.0
414 stars 74 forks source link

I Updated comfyui and all custom node and now I get this. #222

Closed Cedri4 closed 1 month ago

Cedri4 commented 1 month ago

I Updated comfyui and all custom node and now I get this. image In my workflow everything should work the path is correct, I've checked it in file explorer but the interesting part is that when I remove all the widtget and convert them as input it works.

The load video (path) and video combine nodes don't work. image image

Cedri4 commented 1 month ago

Ah ah after a little recreation I got this error. From what I understand for some reason it transforms it into a float image image

AustinMroz commented 1 month ago

There's certainly some spookyness going on here. I don't have a proper reproduction, but I'll share what leads I have. The exact wording of Invalid file path: is produceed from an area with strict safety checks for None. There was a very similar issue (#114) which was eventually traced to the node recieving the string "None" as input.

From my recollection and quick testing, getting multiple lines of "Custom Validation failed for node" was fixed in ComfyUI last December. I realize you said you just updated, but could you double check the version of ComfyUI you're on for my sanity?

Cedri4 commented 1 month ago

image Here's a image that shows that it's up to date, 13 hours after my initial message.

And as you can see on the second image in my second message, the video input is a path but I'll check if the output is the same.

Cedri4 commented 1 month ago

Ok, this is a problem image And now the Load video with path works when I bypass the video combine and the filename thing. But when I debypass them I got a problem. Since my explanation is not the best here's a video that shows the problem.

https://github.com/Kosinkadink/ComfyUI-VideoHelperSuite/assets/93396286/f45d26fe-056a-4928-a822-1df28923dcf0

Cedri4 commented 1 month ago

So after a second look on the terminal this custom node seems to cause a problem by converting the string to a float. image I disable it and now it works :) I guess this custom node broke everything. https://github.com/GMapeSplat/ComfyUI_ezXY