Kosinkadink / ComfyUI-VideoHelperSuite

Nodes related to video workflows
GNU General Public License v3.0
543 stars 95 forks source link

Wrong Input type in frame_rate as >Input< (Not as Widget) (Video Combine 🎥🅥🅗🅢 Node) #234

Open GoldenCrowInf opened 3 months ago

GoldenCrowInf commented 3 months ago

Hello,

I'm having this problem, I've set the frame_rate from Video Combine 🎥🅥🅗🅢 from Widget to Input. When I do it, the required input value is an INT. When I run the workflow, it returns an error saying that the frame_rate input is not a FLOAT.

In previous versions it was working fine, but now it's broken.

I hope it helps!

AustinMroz commented 3 months ago

The frame_rate input was changed to float back in March for compatibility with the frame rate values produced from Load Video/Video Info. If you create a new Video Combine node and convert frame_rate to an input, is it still of type int for you?

GoldenCrowInf commented 3 months ago

Yes, when you turn frame_rate into input, it only accepts INT as input value. this is the problem. If I convert to float, it cannot take the value as input. You cannot connect it as float. Captura de tela 2024-06-19 174145

Captura de tela 2024-06-19 174527

GoldenCrowInf commented 3 months ago

Ok. Nevermind. I was loading an old Workflow. And in this workflow it was using an old version of Video Combine. I made a new workflow and it's working fine. Sorry about that and thank you!