search

Kosinkadink / ComfyUI-VideoHelperSuite

Nodes related to video workflows
GNU General Public License v3.0
443 stars 78 forks source link

Video Combine Nodes video preview stopped working #242

Closed Ginushmal closed 1 week ago

Ginushmal commented 2 weeks ago

After setting up the above workflow, my Video Combine node stop showing the preview of the output video, it get saved but doesn't preview. this happen with other work-spaces where this node is being used. and i try to uninstall and re install these Nodes too, but it didn't fix this issue, any idea why..???? image

AustinMroz commented 2 weeks ago

A fairly major rework to how VHS processes audio was released yesterday. I greatly appreciate the report.

If previews are not displaying even though a playable file has been saved to disk, check the command line. ffmpeg likely ran into an issue when transcoding the preview.

Seperate of that issue, I've fixed the node for converting to the legacy VHS_AUDIO format and added a new node for converting from the legacy VHS_AUDIO format.

SamKhoze commented 2 weeks ago

@AustinMroz I have the same issue

manniee07 commented 1 week ago

Same issue.

Garin2-colab commented 1 week ago

Same issue, here. When I 'disable' DeepFuze, the preview works again.

AustinMroz commented 1 week ago

That gives me a reproduction!

It's a bug outside VHS. but I should be able to work around it and deploy a fix within an hour or so.

AustinMroz commented 1 week ago

I've pushed a workaround., let me know if there are any further issues.

@SamKhoze, I would highly advise you update the beforeRegisterNodeDef in audio_preview.js to only apply to your audio_preview node instead as it currently applies to every node.

SamKhoze commented 1 week ago

@AustinMroz thank you the preview playback window now is enabled. well noted,