search

Kosinkadink / ComfyUI-VideoHelperSuite

Nodes related to video workflows
GNU General Public License v3.0
521 stars 92 forks source link

different video format, different audio length #263

Open cr7Por opened 1 month ago

cr7Por commented 1 month ago

vidprob I use load audio upload with videocombine node, 4 images, framerate=1, if select video/webm format, 4 seconds video with 2 seconds audio will be generated; if selecet video/h264-mp4, 4 seconds video with zero seconds audio(just a beep in the video) will be generated.

cr7Por commented 1 month ago

framerate=1 cause this problem, if set framerate=2, n+2 seconds video will have n seconds audio in it.

AustinMroz commented 1 month ago

It's a very narrow set of set of circumstances, but I am able to reproduce this. When using the older ffmpeg bundled with imageio, the h264 output format, and a frame rate under 4 fps, the output video will either have incorrect audio or for a larger number of frames (6 is the cutoff for me) fail completely at the step for combining audio.

I'll continue digging, but even after enabling verbose logs, I'm not seeing a way to fix this from VHS.

cr7Por commented 1 month ago

It's a very narrow set of set of circumstances, but I am able to reproduce this. When using the older ffmpeg bundled with imageio, the h264 output format, and a frame rate under 4 fps, the output video will either have incorrect audio or for a larger number of frames (6 is the cutoff for me) fail completely at the step for combining audio.

I'll continue digging, but even after enabling verbose logs, I'm not seeing a way to fix this from VHS.

so update ffmpeg will solve this?