search

Kosinkadink / ComfyUI-VideoHelperSuite

Nodes related to video workflows
GNU General Public License v3.0
583 stars 100 forks source link

Display issue #47

Closed robertvoy closed 1 year ago

robertvoy commented 1 year ago

image

There's display issue with the latest update. Using chrome on windows 10.

AustinMroz commented 1 year ago

I've found a way to reproduce the error by zooming with the browser and am working on a proper fix, but in the meantime, does resetting the browser zoom with ctrl+0 cause things to line up again?

AustinMroz commented 1 year ago

I've implemented a fix for the reproduction I found on a seperate testing branch (js_cleanup). but I'd like to do some further testing to make sure it doesn't break anything else and verify that it works for other pontential causes (high dpi) before pushing to main.

makeitrad commented 1 year ago

Doesnt appear to be an issues with zooming on the browser for me. I can change from 100% to 150% and they are always like this. Tested on Chrome and Firefox for MacOS.

makeitrad commented 1 year ago

https://github.com/Kosinkadink/ComfyUI-VideoHelperSuite/assets/22509743/51b0072c-11dc-48cd-bde5-eae0c6f85941

Here is a video to show the behavior. Thx for the help!

AustinMroz commented 1 year ago

That matches what I was able to reproduce.

I've tested the fix on 3 different browsers and 2 operating systems now, and haven't noticed any issues, so I've pushed it to main now. Please let me know if it solves the issue.

Edit: My hunch is that the issue is related to high dpi screens. I don't have a high dpi screen to test with, but the recent fix gave no visual oddities with display scaling enabled in Windows, so I'm fairly confident it will be sufficient to resolve the issue.

makeitrad commented 1 year ago

Works great on my end! Thanks Austin!!

robertvoy commented 1 year ago

Yep that works for me too, thank you!