search

Kosinkadink / ComfyUI-VideoHelperSuite

Nodes related to video workflows
GNU General Public License v3.0
583 stars 100 forks source link

Switching formats blows up some native compatibility for viewing the vidoes #70

Open gateway opened 11 months ago

gateway commented 11 months ago

yuv420p10le(progressive) breaks native viewing on the mac, On the mac you can usually select an item and hit spacebar and it plays the video, or double clicking on it opens it up with quicktime player, now with this change I have to view everything in VLC and cant quick view the video.

image

you can see the icons that have video thumb vs QT logo which doesn't play native anymore. I'm not sure how compatible the progressive format is or why it was added.

new format

Stream #0:0[0x1](und): Video: h264 (High 10) (avc1 / 0x31637661), yuv420p10le(progressive), 1280x720, 2590 kb/s, 24 fps, 24 tbr, 12288 tbn (default)

Older format

Stream #0:0[0x1](und): Video: h264 (High) (avc1 / 0x31637661), yuv420p(progressive), 1280x720, 1148 kb/s, 24 fps, 24 tbr, 12288 tbn (default)

My old ffmpeg settings that i use mainly are similar to this

ffmpeg -f image2 -framerate 23.976 -i 20221128211421_%04d.png -c:v libx264 -preset veryslow -crf 12 -color_primaries 1 -color_trc 1 -colorspace 1 -pix_fmt yuv420p Part10.mp4

This commit is what broke it for me..

https://github.com/Kosinkadink/ComfyUI-VideoHelperSuite/blob/d36f61ff46abbeb6ec33e6499b012c1978a3e634/video_formats/h264-mp4.json#L5

also not sure why but the earlier ones when I upload them to my iphone do not allow me to edit them on my phone either.. (separate issue)

Kosinkadink commented 11 months ago

I've rolled back the changes, pull main and let us know if that fixes your issue!