Kosinkadink / ComfyUI-VideoHelperSuite

Nodes related to video workflows
GNU General Public License v3.0
583 stars 100 forks source link

Webm video missing parameter to support compression setting. #78

Closed alejobrainz closed 10 months ago

alejobrainz commented 11 months ago

I was trying webm compression and found that it was missing a ffmpeg flag that makes the cfr compression parameter useless. Can you consider adding "-b:v", "0" to it? once added you can ser crf to your liking to have quality or lower quality webm videos.

{
    "main_pass":
    [
        "-n",
        "-pix_fmt", "yuv420p",
        "-b:v", "0"
    ],
     "extension": "webm"
}
AustinMroz commented 11 months ago

Thanks for pointing this out.

I'm working on an update that would allow options like crf to only display on formats that support it and was considering removing crf as an option from the simple webm format since there were related issues.

If this solution also works to resolve those issues, it would be greatly preferred.

alejobrainz commented 11 months ago

It worked on my end. Quality is substantially improved on the default 20 crf. I tested values between 0 and 60, with good results.