search

Kosinkadink / ComfyUI-VideoHelperSuite

Nodes related to video workflows
GNU General Public License v3.0
524 stars 92 forks source link

[Bug] Right-click on VHS Video Combine not working #93

Closed GentlemanHu closed 8 months ago

GentlemanHu commented 8 months ago

2023-12-24 17 25 34

GentlemanHu commented 8 months ago

ComfyUI version : https://github.com/comfyanonymous/ComfyUI/commit/a252963f956a7d76344e3f0ce24b1047480a25af

AustinMroz commented 8 months ago

I know from development that this issue occurs when the code that adds options to the menu throws an error, but I've not had any luck with reproducing or guessing at what the current bug might be.

If you open the developer tools -> console, there should be an error message that is produced on right click.

iamaguai commented 8 months ago

comfyui-share-common.js:90 Uncaught TypeError: Cannot read properties of undefined (reading 'format') at getPotentialOutputsAndOutputNodes (comfyui-share-common.js:90:25) at node.getExtraMenuOptions (comfyui-manager.js:1039:35) at LGraphCanvas.getNodeMenuOptions (litegraph.core.js:13208:30) at LGraphCanvas.getNodeMenuOptions (ui_mixlab.js:547:42) at LGraphCanvas.getNodeMenuOptions (groupNode.js:1139:38) at LGraphCanvas.processContextMenu (litegraph.core.js:13330:34) at LGraphCanvas.processMouseDown (litegraph.core.js:6295:10) at LGraphCanvas.processMouseDown (undoRedo.js:144:29) at LGraphCanvas.processMouseDown (app.js:882:37)

AustinMroz commented 8 months ago

The issue appears to be with ComyUI-Manager. It has code specific to our VideoCombine node to try and extract animated images for their "Share Output" button, but that code fails to properly handle the case where a preview doesn't exist yet (the node was just added)

iamaguai commented 8 months ago

The issue appears to be with ComyUI-Manager. It has code specific to our VideoCombine node to try and extract animated images for their "Share Output" button, but that code fails to properly handle the case where a preview doesn't exist yet (the node was just added)

you are right. when i set share :none at manager menu, i create a new VideoCombine, this issue appears.

Kosinkadink commented 8 months ago

Looks like the fix has been merged into the ComfyUI-Manager - I will close the issue for now, but if it still happens for you after updating ComfyUI-Manager, reopen the issue.